[ https://issues.apache.org/jira/browse/YARN-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710720#comment-16710720 ]
Haibo Chen commented on YARN-8738: ---------------------------------- Thanks [~snemeth] for the patch. Two nits: 1) we can replace NegativeResourceDefinitionException with a AllocationConfigurationException and update the diagnostic messages in parseNewStyleResource() accordingly. 2) In addition, all the test cases in TestFairSchedulerConfigurationNegativeResourceValues can be moved to existing testFairSchedulerConfiguration. > FairScheduler configures maxResources or minResources as negative, the value > parse to a positive number. > -------------------------------------------------------------------------------------------------------- > > Key: YARN-8738 > URL: https://issues.apache.org/jira/browse/YARN-8738 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 3.2.0 > Reporter: Sen Zhao > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-8738.001.patch, YARN-8738.002.patch > > > If maxResources or minResources is configured as a negative number, the value > will be positive after parsing. > If this is a problem, I will fix it. If not, the > FairSchedulerConfiguration#parseNewStyleResource parse negative number should > be same with parseOldStyleResource . > cc:[~templedf], [~leftnoteasy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org