[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706715#comment-16706715 ]
Akhil PB edited comment on YARN-8914 at 12/3/18 7:01 AM: --------------------------------------------------------- [~eyang] I have found a few issues. # The Terminal column in attempts table in {{timeline-view.js}} is not a link, it's a plain text now. Please change this to a link. I suppose this is intended to access AM container. # Please add the changes made for {{yarn-container.js}} model and serializer to {{yarn-timeline-container.js}} model and serializer too. # Please remove the requestedUser DOM access and from {{yarn-container.js}} model. # To access requestedUser, you could use the following code to add userInfo to {{yarn-app-attempt.js}} model. Then we can pass in this model to {{timeline-view.js}}. {code} // file: routes/yarn-app-attempt.js // Adding userInfo to the model afterModel(model) { const appContrl = this.controllerFor('application'); model.userInfo = appContrl.get('userInfo'); } {code} {code} // file: templates/yarn-app-attempt.js // Passing userInfo to the timeline-view.js {{timeline-view parent-id="containers-timeline-div" my-id="timeline-view" height="400" rmModel=model.rmContainers tsModel=model.tsContainers label="shortAppAttemptId" attemptModel=false changeViewType="changeViewType" viewType=viewType userInfo=model.userInfo }} {code} Now we could access requested user via following in {{timeline-view.js}}: {code} let requestedUser = ''; // could assign some default user. if (this.get('userInfo')) { requestedUser = this.get('userInfo.requestedUser') } {code} was (Author: akhilpb): [~eyang] I have found a few issues. # The Terminal column in attempts table in {{timeline-view.js}} is not a link, it's a plain text now. Please change this to a link. # Please add the changes made for {{yarn-container.js}} model and serializer to {{yarn-timeline-container.js}} model and serializer too. # Please remove the requestedUser DOM access and from {{yarn-container.js}} model. # To access requestedUser, you could use the following code to add userInfo to {{yarn-app-attempt.js}} model. Then we can pass in this model to {{timeline-view.js}}. {code} // file: routes/yarn-app-attempt.js // Adding userInfo to the model afterModel(model) { const appContrl = this.controllerFor('application'); model.userInfo = appContrl.get('userInfo'); } {code} {code} // file: templates/yarn-app-attempt.js // Passing userInfo to the timeline-view.js {{timeline-view parent-id="containers-timeline-div" my-id="timeline-view" height="400" rmModel=model.rmContainers tsModel=model.tsContainers label="shortAppAttemptId" attemptModel=false changeViewType="changeViewType" viewType=viewType userInfo=model.userInfo }} {code} Now we could access requested user via following in {{timeline-view.js}}: {code} let requestedUser = ''; // could assign some default user. if (this.get('userInfo')) { requestedUser = this.get('userInfo.requestedUser') } {code} > Add xtermjs to YARN UI2 > ----------------------- > > Key: YARN-8914 > URL: https://issues.apache.org/jira/browse/YARN-8914 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-ui-v2 > Reporter: Eric Yang > Assignee: Eric Yang > Priority: Major > Attachments: YARN-8914.001.patch, YARN-8914.002.patch, > YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch, > YARN-8914.006.patch, YARN-8914.007.patch > > > In the container listing from UI2, we can add a link to connect to docker > container using xtermjs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org