[ 
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707522#comment-16707522
 ] 

Eric Yang edited comment on YARN-8914 at 12/4/18 12:43 AM:
-----------------------------------------------------------

[~akhilpb] Thanks for the input.

{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a 
link, it's a plain text now. Please change this to a link. I suppose this is 
intended to access AM container.{quote}

I will remove Terminal column for application attempt.  AM container can be 
accessed from container page only when YARN-8962 patch is applied.

{quote}Please add the changes made for yarn-container.js model and serializer 
to yarn-timeline-container.js model and serializer too.{quote}

I try to repeat what you listed.  However, I have problem to get Graph View to 
be able to resolve requestedUser using the code that you listed.  What changes 
should be done to serializer?

{quote}To access requestedUser, you could use the following code to add 
userInfo to yarn-app-attempt.js model. Then we can pass in this model to 
timeline-view.js.{quote}

Grid view works by adding the routes/yarn-app-attempt.js and 
templates/yarn-app-attempt.js changes, and timeline-view.js having:

{code}
  requestedUser: function() {
    if (this.get('userInfo')) {
      return this.get('userInfo.requestedUser');
    }
    return '';
  }
{code}



was (Author: eyang):
[~akhilpb] Thanks for the input.

{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a 
link, it's a plain text now. Please change this to a link. I suppose this is 
intended to access AM container.{quote}

I will make javascript fix for this JIRA.  AM container can only be accessed 
when YARN-8962 patch is applied.

{quote}Please add the changes made for yarn-container.js model and serializer 
to yarn-timeline-container.js model and serializer too.{quote}

If I understand the code correctly, yarn-timeline-container.js is used for 
displaying history of container information.  It is not possible to login to 
container when data is display through yarn-timeline-container.js.  This is the 
reason that the same code is not applied to yarn-timeline-container.js.

{quote}To access requestedUser, you could use the following code to add 
userInfo to yarn-app-attempt.js model. Then we can pass in this model to 
timeline-view.js.{quote}

Thanks for the tip.  I will incorporate this in the next patch.


> Add xtermjs to YARN UI2
> -----------------------
>
>                 Key: YARN-8914
>                 URL: https://issues.apache.org/jira/browse/YARN-8914
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-ui-v2
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: YARN-8914.001.patch, YARN-8914.002.patch, 
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch, 
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker 
> container using xtermjs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to