[ 
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715796#comment-16715796
 ] 

Eric Yang edited comment on YARN-9089 at 12/11/18 5:08 PM:
-----------------------------------------------------------

[~akhilpb] Thank you for the review.  Agree that models are not meant for code 
execution.  The code will be revised.  Is the intend to use loader.js to set 
ENV.[namespace]=[ajax] value for YARN configuration?  Is there a convention to 
follow?  A example might help with the coding style.  Thanks.

{quote}Do we need this code? Since you are adding userInfo to 
yarn-component-instance/info route, it should be available in info.hbs page in 
model object. I am not sure passing params to outlet works or not in 
ember.{quote}

You are right.  The parameter passing can be removed.  Thanks


was (Author: eyang):
[~akhilpb] Thank you for the review.  Agree that models are not meant for code 
execution.  The code will be revised.  Is the intend to use loader.js to set 
ENV.[namespace]=[ajax] value for YARN configuration?  Is there a convention to 
follow?  A example might help with the coding style.  Thanks.

{quote}Do we need this code? Since you are adding userInfo to 
yarn-component-instance/info route, it should be available in info.hbs page in 
model object. I am not sure passing params to outlet works or not in 
ember.\{quote}

You are right.  The parameter passing can be removed.  Thanks

> Add Terminal Link to Service component instance page for UI2
> ------------------------------------------------------------
>
>                 Key: YARN-9089
>                 URL: https://issues.apache.org/jira/browse/YARN-9089
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-ui-v2
>    Affects Versions: 3.3.0
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: YARN-9089.001.patch
>
>
> In UI2, Service > Component > Component Instance uses Timeline server to 
> aggregate information about Service component instance.  Timeline server does 
> not have the full information like the port number of the node manager, or 
> the web protocol used by the node manager.  It requires some changes to 
> aggregate node manager information into Timeline server in order to compute 
> the Terminal link.  For reducing the scope of YARN-8914, it is better file 
> this as a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to