[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718561#comment-16718561
]
Akhil PB edited comment on YARN-9089 at 12/12/18 7:38 AM:
----------------------------------------------------------
[~eyang] Couple of comments.
# We don't need
{noformat}
termLink: DS.attr('string')
{noformat}
in {{models/yarn-component-instance.js}}. Since termLink is a computed
property bases on node and containerId.
# The line
{noformat}
termLink: Ember.computed('termLink', function ()
{noformat}
should be
{noformat}
termLink: Ember.computed('node', 'containerId', function()
{noformat}
# Please use {{ window.location.protocol }} instead of \{{ location.protocol
}} (eventhough both are same) to show clearly that we are accessing browser
protocal property, not some local variable or something.
was (Author: akhilpb):
[~eyang] Couple of comments.
# We don't need {{termLink: DS.attr('string')}} in
{{models/yarn-component-instance.js}}. Since termLink is a computed property
bases on node and containerId.
# {{termLink: Ember.computed('termLink', function() }} should be {{termLink:
Ember.computed('node', 'containerId', function() }}
# Please use {{ window.location.protocol }} instead of {{ location.protocol }}
(eventhough both are same) to show clearly that we are accessing browser
protocal property, not some local variable or something.
> Add Terminal Link to Service component instance page for UI2
> ------------------------------------------------------------
>
> Key: YARN-9089
> URL: https://issues.apache.org/jira/browse/YARN-9089
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
> Affects Versions: 3.3.0
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Attachments: YARN-9089.001.patch, YARN-9089.002.patch
>
>
> In UI2, Service > Component > Component Instance uses Timeline server to
> aggregate information about Service component instance. Timeline server does
> not have the full information like the port number of the node manager, or
> the web protocol used by the node manager. It requires some changes to
> aggregate node manager information into Timeline server in order to compute
> the Terminal link. For reducing the scope of YARN-8914, it is better file
> this as a separate task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
