[ https://issues.apache.org/jira/browse/YARN-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738016#comment-16738016 ]
Ayush Saxena commented on YARN-8498: ------------------------------------ Thanx [~sunilg] for the review. I guess sys/wat.h is also not having this macro in 18.04 It is peresent in ver 14.04 here https://github.com/trailofbits/abigen/blob/master/data/platforms/ubuntu/14.04.5/usr/include/x86_64-linux-gnu/sys/wait.h#L71 But not in 18.04 here : https://github.com/trailofbits/abigen/blob/master/data/platforms/ubuntu/18.04.1/usr/include/sys/wait.h IIRC There used to be some problem of multiple definitions conflicts too when stdlib.h and sys/wait.h were used together.Don't know whether that has been resolved now. If we want to use macro only. We can define explicitly if not defined in the code using #ifndef _WAIT_STATUS then define it. Not sure that will optimize anything in this case. MACRO just replaces the word with definition.By functionality point of view I guess there shouldn't be any as such problem. > Yarn NodeManager OOM Listener Fails Compilation on Ubuntu 18.04 > --------------------------------------------------------------- > > Key: YARN-8498 > URL: https://issues.apache.org/jira/browse/YARN-8498 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Jack Bearden > Assignee: Ayush Saxena > Priority: Blocker > Attachments: YARN-8948-01.patch > > > While building this project, I ran into a few compilation errors here. The > first one was in this file: > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/impl/oom_listener_main.c > At the very end, during the compilation of the OOM test, it fails again: > > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:256:7: > error: ‘__WAIT_STATUS’ was not declared in this scope > __WAIT_STATUS mem_hog_status = {}; > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:257:30: > error: ‘mem_hog_status’ was not declared in this scope > __pid_t exited0 = wait(mem_hog_status); > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:275:21: > error: expected ‘;’ before ‘oom_listener_status’ > __WAIT_STATUS oom_listener_status = {}; > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:276:30: > error: ‘oom_listener_status’ was not declared in this scope > __pid_t exited1 = wait(oom_listener_status); > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org