[ https://issues.apache.org/jira/browse/YARN-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738433#comment-16738433 ]
Ayush Saxena commented on YARN-8498: ------------------------------------ Thanx [~jlowe] for giving a look. {quote}That's going to cause problems if a system ever decides to not typedef pid_t to __pid_t, and systems are completely free to make that choice in the future. Same goes for __WAIT_STATUS. {quote} That is what something happened for __WAIT_STATUS . As of now _pid_t still seems to be present in GCC 7.But we definitely can't be sure regarding its future too.Moreover I guess using these macros is not helping us too in no way. I have changed __pid_t to pid_t too in v2 as a preventive measure. If someone wants to give a check that __pid_t is same as pid_t , can check [here|https://github.com/trailofbits/abigen/blob/master/data/platforms/ubuntu/18.04.1/usr/include/sys/types.h#L98] > Yarn NodeManager OOM Listener Fails Compilation on Ubuntu 18.04 > --------------------------------------------------------------- > > Key: YARN-8498 > URL: https://issues.apache.org/jira/browse/YARN-8498 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Jack Bearden > Assignee: Ayush Saxena > Priority: Blocker > Attachments: YARN-8498-02.patch, YARN-8948-01.patch > > > While building this project, I ran into a few compilation errors here. The > first one was in this file: > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/impl/oom_listener_main.c > At the very end, during the compilation of the OOM test, it fails again: > > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:256:7: > error: ‘__WAIT_STATUS’ was not declared in this scope > __WAIT_STATUS mem_hog_status = {}; > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:257:30: > error: ‘mem_hog_status’ was not declared in this scope > __pid_t exited0 = wait(mem_hog_status); > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:275:21: > error: expected ‘;’ before ‘oom_listener_status’ > __WAIT_STATUS oom_listener_status = {}; > hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/oom-listener/test/oom_listener_test_main.cc:276:30: > error: ‘oom_listener_status’ was not declared in this scope > __pid_t exited1 = wait(oom_listener_status); > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org