[ https://issues.apache.org/jira/browse/YARN-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773708#comment-16773708 ]
Wilfred Spiegelenburg commented on YARN-9298: --------------------------------------------- Thank you for the review [~yufeigu] it took a bit longer than expected working on 4 and 5 without polluting the code too much. 1) done added to all files changed 2) added tests for: * FairQueuePlacementUtils * PlacementFactory * PlacementRule (FS added parts) 3) removed the extra line 4) That is how I started the implementation. I ran into a number of problems while instantiating the rules in the policy and then moved to this model. I have it working now without polluting the factory and or rule with lots of FS specific classes. 5) Done that as part of the rewrite for 4) 6) updated the javadoc for the method 7) fixed 8) removed, the exception is already logged higher up in the stack > Implement FS placement rules using PlacementRule interface > ---------------------------------------------------------- > > Key: YARN-9298 > URL: https://issues.apache.org/jira/browse/YARN-9298 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Reporter: Wilfred Spiegelenburg > Assignee: Wilfred Spiegelenburg > Priority: Major > Attachments: YARN-9298.001.patch, YARN-9298.002.patch > > > Implement existing placement rules of the FS using the PlacementRule > interface. > Preparation for YARN-8967 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org