[ https://issues.apache.org/jira/browse/YARN-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782911#comment-16782911 ]
Yufei Gu commented on YARN-9298: -------------------------------- [~wilfreds], thanks for the patch. Looks really good! Just some nits: 1. There are unused imports in class FairQueuePlacementUtils and class PlacementRule 2. {{private PlacementRule parentRule = null;}}, no need set it to null as a class member since the default is null. 3. {{protected boolean createQueue = false;}}, I suggest to remove the initialization or set it to true since it will be set to true by default anyway. > Implement FS placement rules using PlacementRule interface > ---------------------------------------------------------- > > Key: YARN-9298 > URL: https://issues.apache.org/jira/browse/YARN-9298 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Reporter: Wilfred Spiegelenburg > Assignee: Wilfred Spiegelenburg > Priority: Major > Attachments: YARN-9298.001.patch, YARN-9298.002.patch, > YARN-9298.003.patch, YARN-9298.004.patch, YARN-9298.005.patch > > > Implement existing placement rules of the FS using the PlacementRule > interface. > Preparation for YARN-8967 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org