[
https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774779#comment-16774779
]
Wilfred Spiegelenburg commented on YARN-9323:
---------------------------------------------
Hi [~snemeth] Some comments on this change as it includes a number of changes
that are not related to fixing the issue.
These changes just increase the size of the fix:
* The {{FairScheduler}} change seems to be just a layout change
* in the FSLeafQueue we have similar changes around {{setMemorySize}} and
{{setVirtualCores}}
* {{computeMaxAMResource}} javadoc changes are unneeded
* import re-ordering in the TestFSLeafQueue is unneeded
These two should be fixed:
* checkstyle issue: _MAX_AM_SHARE_ in {{TestFSLeafQueue}} should be final
* whitespace issue: line 219 of the patch
The rest should wait until we have a test run with YARN-9322 committed
> FSLeafQueue#computeMaxAMResource does not override zero values for custom
> resources
> -----------------------------------------------------------------------------------
>
> Key: YARN-9323
> URL: https://issues.apache.org/jira/browse/YARN-9323
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9323.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
