[ https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779861#comment-16779861 ]
Daniel Templeton commented on YARN-9323: ---------------------------------------- Looking at {{FSLeafQueue.computeMaxAMResource()}}, I'm worried that we're strewing the innards of the metrics class out all over the place. Instead, could we maybe move most of {{computeMaxAMResource()}} into a "fill in" method in {{QueueMetrics}} that takes the fair share as a parameter, clones it, and fills in the values that are 0. For the sake of getting this JIRA in, let's do that in a follow-up JIRA. > FSLeafQueue#computeMaxAMResource does not override zero values for custom > resources > ----------------------------------------------------------------------------------- > > Key: YARN-9323 > URL: https://issues.apache.org/jira/browse/YARN-9323 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-9323.001.patch, YARN-9323.002.patch, > YARN-9323.003.patch, YARN-9323.004.patch, YARN-9323.005.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org