[ 
https://issues.apache.org/jira/browse/YARN-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782932#comment-16782932
 ] 

Wilfred Spiegelenburg commented on YARN-9298:
---------------------------------------------

# saw that, had them already fixed in a new version
# fixed that one and also made the {{QueueManager}} private and introduced a 
getter for it. It is only set in the class itself and needed outside when the 
parent rule is run (that fixes the 3rd checkstyle issue)
# It should have been true from the start, changed the init to true.

Removed two unneeded casts also in the {{setConfig}} method.

I think that is it [~yufeigu]

> Implement FS placement rules using PlacementRule interface
> ----------------------------------------------------------
>
>                 Key: YARN-9298
>                 URL: https://issues.apache.org/jira/browse/YARN-9298
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>         Attachments: YARN-9298.001.patch, YARN-9298.002.patch, 
> YARN-9298.003.patch, YARN-9298.004.patch, YARN-9298.005.patch, 
> YARN-9298.006.patch
>
>
> Implement existing placement rules of the FS using the PlacementRule 
> interface.
> Preparation for YARN-8967



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to