[ https://issues.apache.org/jira/browse/YARN-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799638#comment-13799638 ]
Tsuyoshi OZAWA commented on YARN-1305: -------------------------------------- After reading Karthik's comment, I was thinking use cases when we enable RM HA configuration without multiple RM ids. It's useful in following cases: 1. Developing. 2. Testing. 3. Manual failover(?) Therefore, we should support it IMO. I came up with another idea to support "strict mode" to stop RM with a wrong configuration when RM startup as Bikas mentioned. It's useful to detect wrong operations. However, it's not time to do this IMO, because we're still developing RM HA now. After getting stable, we should support the "strict mode". Thoughts? > RMHAProtocolService#serviceInit should handle HAUtil's > IllegalArgumentException > ------------------------------------------------------------------------------- > > Key: YARN-1305 > URL: https://issues.apache.org/jira/browse/YARN-1305 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.2.1 > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Labels: ha > Attachments: YARN-1305.1.patch, YARN-1305.2.patch, YARN-1305.3.patch, > YARN-1305.4.patch > > > When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit > calls HAUtil.setAllRpcAddresses. If the configuration values are null, it > just throws IllegalArgumentException. > It's messy to analyse which keys are null, so we should handle it and log the > name of keys which are null. > A current log dump is as follows: > {code} > 2013-10-15 06:24:53,431 INFO > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: registered > UNIX signal handlers for [TERM, HUP, INT] > 2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: > Service RMHAProtocolService failed in state INITED; cause: > java.lang.IllegalArgumentException: Property value must not be null > java.lang.IllegalArgumentException: Property value must not be null > at > com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:816) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:798) > at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100) > at > org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105) > at > org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60) > at > org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at > org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108) > at > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187) > at > org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940) > {code} -- This message was sent by Atlassian JIRA (v6.1#6144)