[ https://issues.apache.org/jira/browse/YARN-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797071#comment-13797071 ]
Hadoop QA commented on YARN-1305: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608757/YARN-1305.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2190//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2190//console This message is automatically generated. > RMHAProtocolService#serviceInit should handle HAUtil's > IllegalArgumentException > ------------------------------------------------------------------------------- > > Key: YARN-1305 > URL: https://issues.apache.org/jira/browse/YARN-1305 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.2.1 > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Labels: ha > Attachments: YARN-1305.1.patch, YARN-1305.2.patch, YARN-1305.3.patch > > > When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit > calls HAUtil.setAllRpcAddresses. If the configuration values are null, it > just throws IllegalArgumentException. > It's messy to analyse which keys are null, so we should handle it and log the > name of keys which are null. > A current log dump is as follows: > {code} > 2013-10-15 06:24:53,431 INFO > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: registered > UNIX signal handlers for [TERM, HUP, INT] > 2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: > Service RMHAProtocolService failed in state INITED; cause: > java.lang.IllegalArgumentException: Property value must not be null > java.lang.IllegalArgumentException: Property value must not be null > at > com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:816) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:798) > at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100) > at > org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105) > at > org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60) > at > org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at > org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108) > at > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187) > at > org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > at > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940) > {code} -- This message was sent by Atlassian JIRA (v6.1#6144)