[ 
https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803542#comment-13803542
 ] 

Zhijie Shen commented on YARN-947:
----------------------------------

Thanks for the comments. Having discussion with [~vinodkv] and 
[~mayank_bansal]. Here's some update:

1. Remove PBImpl, and change XXXXHistoryData to a simple object that containing 
of the fields. Discuss the issue of changing readers to XXXXReport directly in 
a follow up ticket.

2. Now we can only modify the yarn_protos and YarnApplicationAttemptState to 
add the new state enum. Need to file a follow up ticket to update the 
conversion method in RMServerUtils whenever YARN-891 is done


> Defining the history data classes for the implementation of the 
> reading/writing interface
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-947
>                 URL: https://issues.apache.org/jira/browse/YARN-947
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>             Fix For: YARN-321
>
>         Attachments: YARN-947.1.patch, YARN-947.2.patch, YARN-947.3.patch, 
> YARN-947.4.patch, YARN-947.5.patch, YARN-947.6.patch
>
>
> We need to define the history data classes have the exact fields to be 
> stored. Therefore, all the implementations don't need to have the duplicate 
> logic to exact the required information from RMApp, RMAppAttempt and 
> RMContainer.
> We use protobuf to define these classes, such that they can be ser/des 
> to/from bytes, which are easier for persistence.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to