[ https://issues.apache.org/jira/browse/YARN-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937061#comment-16937061 ]
Manikandan R commented on YARN-9840: ------------------------------------ [~pbacsko] Thanks for your review. Addressed all your comments. Attached .002.patch. {quote}What if there's no secondary group and we return {{null}}? Can't it cause an NPE somewhere else? {quote} In this case, it does't throw any exception and makes use of 'default' queue. Newly added asserts covers this. Also debug log has been added. {quote}One more thing - this enhancement should be documented. {quote} Require some more clarity as mentioned in https://issues.apache.org/jira/browse/YARN-9841?focusedCommentId=16937024&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16937024. Will do in next patch. > Capacity scheduler: add support for Secondary Group rule mapping > ---------------------------------------------------------------- > > Key: YARN-9840 > URL: https://issues.apache.org/jira/browse/YARN-9840 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler > Reporter: Peter Bacsko > Assignee: Manikandan R > Priority: Major > Attachments: YARN-9840.001.patch, YARN-9840.002.patch > > > Currently, Capacity Scheduler only supports primary group rule mapping like > this: > {{u:%user:%primary_group}} > Fair scheduler already supports secondary group placement rule. Let's add > this to CS to reduce the feature gap. > Class of interest: > https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/UserGroupMappingPlacementRule.java -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org