[ https://issues.apache.org/jira/browse/YARN-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949444#comment-16949444 ]
Szilard Nemeth commented on YARN-9840: -------------------------------------- Hi [~maniraj...@gmail.com]! Just a quick question: In the added code in UserGroupMappingPlacementRule#getPlacementForUser: You are starting the loop from index 1. I guess ithis is because the primary group is at the 0th index and all the seconday groups are from higher indices. Is this statement true? Can you make this straightforward with some code comment? As this is kind of a new feature in CS, can you modify the documentation of CS as well? Thanks! > Capacity scheduler: add support for Secondary Group rule mapping > ---------------------------------------------------------------- > > Key: YARN-9840 > URL: https://issues.apache.org/jira/browse/YARN-9840 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacity scheduler > Reporter: Peter Bacsko > Assignee: Manikandan R > Priority: Major > Attachments: YARN-9840.001.patch, YARN-9840.002.patch, > YARN-9840.003.patch > > > Currently, Capacity Scheduler only supports primary group rule mapping like > this: > {{u:%user:%primary_group}} > Fair scheduler already supports secondary group placement rule. Let's add > this to CS to reduce the feature gap. > Class of interest: > https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/UserGroupMappingPlacementRule.java -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org