[
https://issues.apache.org/jira/browse/YARN-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028478#comment-17028478
]
Manikandan R edited comment on YARN-10043 at 2/2/20 4:47 PM:
-------------------------------------------------------------
[~pbacsko] Thanks for your reviews.
# Taken care.
# Compare demands ensures entity without resource demand get lower priority
than ones who have demands. When both entities has certain demands ( > 0), then
there is no actual comparison. Hence the changes are in that way. It has been
commented too at class level. Similar to {{FairSharePolicy}} implementation.
# For #3 and #4, yes there are multiple asserts intended to clearly show the
expected final ones are passing after asserting all earlier comparison (in the
precedence order) has been passed as well. However, I see your point and made
the changes by balancing both the views.
was (Author: maniraj...@gmail.com):
[~pbacsko] Thanks for your reviews.
# Taken care.
# Compare demands ensures entity without resource demand get lower priority
than ones who have demands. When both entities has certain demands ( > 0), then
there is no actual comparison. Hence the changes are in that way. It has been
commented too at class level. Similar to {{FairSharePolicy}} implementation.
# For #3 and #4, yes there are multiple asserts intended to clearly show the
expected final ones are passing after asserting all earlier comparison (in the
precedence order) has been passed as well. However, I see your point and made
the changes by balancing both the views.
> FairOrderingPolicy Improvements
> -------------------------------
>
> Key: YARN-10043
> URL: https://issues.apache.org/jira/browse/YARN-10043
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-10043.001.patch, YARN-10043.002.patch,
> YARN-10043.003.patch
>
>
> FairOrderingPolicy can be improved by using some of the approaches (only
> relevant) implemented in FairSharePolicy of FS. This improvement has
> significance in FS to CS migration context.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
