[ 
https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060026#comment-17060026
 ] 

Bilwa S T commented on YARN-9995:
---------------------------------

Hi [~snemeth] I have a small doubt. Why do we need a Builder for 
SchedConfUpdateInfo?? I can see that there are no set operations done for 
SchedConfUpdateInfo object. All are get operations. Builder is needed only when 
many values need to be set to create an object right??

> Code cleanup in TestSchedConfCLI
> --------------------------------
>
>                 Key: YARN-9995
>                 URL: https://issues.apache.org/jira/browse/YARN-9995
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Bilwa S T
>            Priority: Minor
>
> Some tests are too verbose: 
> - add / delete / remove queues testcases: A Builder for SchedConfUpdateInfo 
> could be created as this object is frequently created.
> - Some fields can be converted to local variables: sysOutStream, sysOut, 
> sysErr, csConf
> - Any additional cleanup



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to