[ 
https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099573#comment-17099573
 ] 

Adam Antal commented on YARN-10257:
-----------------------------------

Thanks for the patch [~pbacsko]! Do you plan to do something with regards to 
the first item from the description?  (I mean the {{increment-allocation}} 
properties).
Regarding the system exit code check I see that we have {{system-rules}} 
artifact in the hadoop pom that might be a better choice to check the exit 
code. (See 
[ExpectedSystemExit|https://stefanbirkner.github.io/system-rules/index.html#ExpectedSystemExit]
 JUnit rule)

> FS-CS converter: skip increment properties for mem/vcores and fix DRF check
> ---------------------------------------------------------------------------
>
>                 Key: YARN-10257
>                 URL: https://issues.apache.org/jira/browse/YARN-10257
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-10257-001.patch
>
>
> Two issues have been discovered during fs2cs testing:
> 1. The conversion of allocation increment properties are not needed:
> {{yarn.scheduler.increment-allocation-mb}}
> {{yarn.scheduler.increment-allocation-vcores}}
> {{yarn.resource-types.memory-mb.increment-allocation}}
> {{yarn.resource-types.vcores.increment-allocation}}
> 2. The following piece of code is incorrect - the default scheduling policy 
> can be different from DRF, which is a problem if DRF is used everywhere else:
> {code}
>   private boolean isDrfUsed(FairScheduler fs) {
>     FSQueue rootQueue = fs.getQueueManager().getRootQueue();
>     AllocationConfiguration allocConf = fs.getAllocationConfiguration();
>     String defaultPolicy = allocConf.getDefaultSchedulingPolicy().getName();
>     if (DominantResourceFairnessPolicy.NAME.equals(defaultPolicy)) {
>       return true;
>     } else {
>       return isDrfUsedOnQueueLevel(rootQueue);
>     }
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to