[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099929#comment-17099929 ]
Hudson commented on YARN-10257: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18218 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18218/]) YARN-10257. FS-CS converter: skip increment properties for mem/vcores (snemeth: rev cb6399c1095af52112cbf4356572d99923d694ae) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSYarnSiteConverter.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverterMain.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSYarnSiteConverter.java > FS-CS converter: skip increment properties for mem/vcores and fix DRF check > --------------------------------------------------------------------------- > > Key: YARN-10257 > URL: https://issues.apache.org/jira/browse/YARN-10257 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Fix For: 3.4.0, 3.3.1 > > Attachments: YARN-10257-001.patch, YARN-10257-002.patch > > > Two issues have been discovered during fs2cs testing: > 1. The conversion of allocation increment properties are not needed: > {{yarn.scheduler.increment-allocation-mb}} > {{yarn.scheduler.increment-allocation-vcores}} > {{yarn.resource-types.memory-mb.increment-allocation}} > {{yarn.resource-types.vcores.increment-allocation}} > 2. The following piece of code is incorrect - the default scheduling policy > can be different from DRF, which is a problem if DRF is used everywhere else: > {code} > private boolean isDrfUsed(FairScheduler fs) { > FSQueue rootQueue = fs.getQueueManager().getRootQueue(); > AllocationConfiguration allocConf = fs.getAllocationConfiguration(); > String defaultPolicy = allocConf.getDefaultSchedulingPolicy().getName(); > if (DominantResourceFairnessPolicy.NAME.equals(defaultPolicy)) { > return true; > } else { > return isDrfUsedOnQueueLevel(rootQueue); > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org