[ https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124985#comment-17124985 ]
Jim Brennan commented on YARN-9903: ----------------------------------- We have been running with this patch in branch-2.8 for years on many large production clusters, so yes, it is safe. We currently use node-labels sparingly. I'm not sure if they were used more heavily in the past. [~epayne] could speak to that. Note that this patch does not currently have a test case. I was about to start working on this and discovered this Jira and YARN-10283 and thought I should offer up what we have. > Support reservations continue looking for Node Labels > ----------------------------------------------------- > > Key: YARN-9903 > URL: https://issues.apache.org/jira/browse/YARN-9903 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Tarun Parimi > Assignee: Jim Brennan > Priority: Major > Attachments: YARN-9903.001.patch, YARN-9903.002.patch > > > YARN-1769 brought in reservations continue looking feature which improves the > several resource reservation scenarios. However, it is not handled currently > when nodes have a label assigned to them. This is useful and in many cases > necessary even for Node Labels. So we should look to support this for node > labels also. > For example, in AbstractCSQueue.java, we have the below TODO. > {code:java} > // TODO, now only consider reservation cases when the node has no label > if (this.reservationsContinueLooking && nodePartition.equals( > RMNodeLabelsManager.NO_LABEL) && Resources.greaterThan( resourceCalculator, > clusterResource, resourceCouldBeUnreserved, Resources.none())) { > {code} > cc [~sunilg] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org