[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144432#comment-17144432
]
Eric Payne commented on YARN-9903:
----------------------------------
Thanks [~Jim_Brennan] for the updated patch. I have a question about the unit
test {{testContainerReservationContinueLookingWithDefaultLabels}}. Am I correct
in that this test although the app in the test doesn't request labelled
resources, it still is using resources on labelled nodes because the label is
non-exclusive? If so, was the purpose to test that it works the same in that
case?
> Support reservations continue looking for Node Labels
> -----------------------------------------------------
>
> Key: YARN-9903
> URL: https://issues.apache.org/jira/browse/YARN-9903
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Tarun Parimi
> Assignee: Jim Brennan
> Priority: Major
> Attachments: YARN-9903.001.patch, YARN-9903.002.patch,
> YARN-9903.003.patch, YARN-9903.004.patch
>
>
> YARN-1769 brought in reservations continue looking feature which improves the
> several resource reservation scenarios. However, it is not handled currently
> when nodes have a label assigned to them. This is useful and in many cases
> necessary even for Node Labels. So we should look to support this for node
> labels also.
> For example, in AbstractCSQueue.java, we have the below TODO.
> {code:java}
> // TODO, now only consider reservation cases when the node has no label
> if (this.reservationsContinueLooking && nodePartition.equals(
> RMNodeLabelsManager.NO_LABEL) && Resources.greaterThan( resourceCalculator,
> clusterResource, resourceCouldBeUnreserved, Resources.none())) {
> {code}
> cc [~sunilg]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
