[ https://issues.apache.org/jira/browse/YARN-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153234#comment-17153234 ]
Bibin Chundatt commented on YARN-10335: --------------------------------------- Thank you [~cyrusjackson25] for working in this Few comments: # Refer NodeHealthStatus for how the records needs to implemented. Define as abstract and also add comments. # setNodeResources -> setNodeResourceScore also rename the variables too. # Finding addition description detail why did we add this ?? {noformat} optional string node_health_description = 4; {noformat} # NodeHealthService instead of *getNodeHealthDetails* we could add updateNodeHealthDetails # Add Visibility Annotation as private > Improve scheduling of containers based on node health > ----------------------------------------------------- > > Key: YARN-10335 > URL: https://issues.apache.org/jira/browse/YARN-10335 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Bibin Chundatt > Assignee: Cyrus Jackson > Priority: Major > Attachments: YARN-10335.001.patch > > > YARN-7494 supports providing interface to choose nodeset for scheduler > allocation. > We could leverage the same to support allocation of containers based on node > health value send from nodemanagers -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org