[ https://issues.apache.org/jira/browse/YARN-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247718#comment-17247718 ]
zhuqi commented on YARN-10504: ------------------------------ Thanks [~wangda] a lot. It's my honor to work with you. After review the YARN-10504.ver-2.patch code, i have some comments: The change makes our logic more clear. 1. The greate change for setupConfigurableCapacities : {code:java} protected void setupConfigurableCapacities( CapacitySchedulerConfiguration configuration) { CSQueueUtils.loadCapacitiesByLabelsFromConf(getQueuePath(), queueCapacities, configuration); } {code} It's more clear here, can we just load the capacity from conf for queues, without update absolute resources. 2. And update absolute and weight_mode(absolute) in a new Recursion ,the code is: {code:java} root.updateClusterResource(csContext.getClusterResource(){code} Based on it, we should do a lot of things.I am willing to help with it. > Implement weight mode in Capacity Scheduler > ------------------------------------------- > > Key: YARN-10504 > URL: https://issues.apache.org/jira/browse/YARN-10504 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Benjamin Teke > Assignee: zhuqi > Priority: Major > Attachments: YARN-10504.001.patch, YARN-10504.ver-1.patch, > YARN-10504.ver-2.patch > > > To allow the possibility to flexibly create queues in Capacity Scheduler a > weight mode should be introduced. The existing \{{capacity }}property should > be used with a different syntax, i.e: > root.users.capacity = (1.0) or ~1.0 or ^1.0 or @1.0 > root.users.capacity = 1.0w > root.users.capacity = w:1.0 > Weight support should not impact the existing functionality. > > The new functionality should: > * accept and validate the new weight values > * enforce a singular mode on the whole queue tree > * (re)calculate the relative (percentage-based) capacities based on the > weights during launch and every time the queue structure changes -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org