[ https://issues.apache.org/jira/browse/YARN-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261774#comment-17261774 ]
Wangda Tan commented on YARN-10504: ----------------------------------- 1) AbstractCSQueue, lots of format changes, can we revert all format change (change spaces). Since it will cause issues when backport and reviews 2) LeafQueue: There're two TODOs: //TODO recalculate max applications because they can depend on capacity //TODO recalculate max applications because they can depend on capacity I think it took care by the {{updateAbsoluteCapacitiesAndRelatedFields}}, please double check, and if it is correct, we should remove the TODOs 3) TestAbsoluteResourceWithAutoQueue: I added a TODO: TODO: Wangda: I think this test case is not correct, Sunil could help look // into details. 4) TestCapacitySchedulerAutoCreatedQueueBase.java I also added a TODO // TODO: Wangda, I think this is a wrong test, it doesn't consider rounding ... [~bteke], [~gandras], [~zhuqi] if any of you plan to make change to the patch, please add a comment to the JIRA so others will know, otherwise the patch will be hard to merge. > Implement weight mode in Capacity Scheduler > ------------------------------------------- > > Key: YARN-10504 > URL: https://issues.apache.org/jira/browse/YARN-10504 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Benjamin Teke > Assignee: Benjamin Teke > Priority: Major > Attachments: YARN-10504.001.patch, YARN-10504.002.patch, > YARN-10504.003.patch, YARN-10504.004.patch, YARN-10504.005.patch, > YARN-10504.ver-1.patch, YARN-10504.ver-2.patch, YARN-10504.ver-3.patch > > > To allow the possibility to flexibly create queues in Capacity Scheduler a > weight mode should be introduced. The existing \{{capacity }}property should > be used with a different syntax, i.e: > root.users.capacity = (1.0) or ~1.0 or ^1.0 or @1.0 > root.users.capacity = 1.0w > root.users.capacity = w:1.0 > Weight support should not impact the existing functionality. > > The new functionality should: > * accept and validate the new weight values > * enforce a singular mode on the whole queue tree > * (re)calculate the relative (percentage-based) capacities based on the > weights during launch and every time the queue structure changes -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org