[
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264108#comment-17264108
]
Andras Gyori commented on YARN-10506:
-------------------------------------
Uploaded v11 revision of patch, in which the following changes were made:
* Fixed the findbug issue with copy constructor instead of clone
* Fixed numerous checkstyle issues
* Simplified logic in getCapacityConfigurationTypeForQueues. This broke a lot
of tests. The logic is the following: Weight mode if no child queues and if
weight mode is used for siblings, abs mode when it is used, and percentage mode
in every other cases.
What we still need to do:
* Property name and ApplicationPlacementContext behavior (let it drive the
logic or not)
* Also I could not think of a test case, where we have an empty static queue.
I think it is not possible. For empty dynamic parentqueues, I think we already
cover this case when we create a 2 levels queue (In case of
root.a.a1-auto.a2-auto, a1-auto will be a ParentQueue with 0 children, when we
assign a2-auto to it)
> Update queue creation logic to use weight mode and allow the flexible
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-10506
> URL: https://issues.apache.org/jira/browse/YARN-10506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10506-006-10504-010.patch,
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch,
> YARN-10506.001.patch, YARN-10506.002.patch, YARN-10506.003.patch,
> YARN-10506.004.patch, YARN-10506.005.patch, YARN-10506.006-combined.patch,
> YARN-10506.006.patch, YARN-10506.007.patch, YARN-10506.009.patch,
> YARN-10506.011.patch
>
>
> The queue creation logic should be updated to use weight mode and support the
> flexible creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
