[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264390#comment-17264390 ]
Wangda Tan commented on YARN-10506: ----------------------------------- [~zhuqi], [~gandras], I just took a look at the latest patch, here's my comment: I think we still need to make a conclusion for the following items: *1) How we deal with "create" flag of ApplicationPlacementContext?* Based on latest patch, we have two flags added to ApplicationPlacementContext. But we only do one {code:java} if (apc.isCreateLeafQueue() || apc.isCreateParentQueue()) { ... LeafQueue lq = autoQueueHandler.autoCreateQueue(apc); } {code} And we hardcoded the two values: {code:java} apc.setCreateParentQueue(true); apc.setCreateLeafQueue(true); {code} To me, It is not sufficient, we need to check inside the handler: {code:java} if (apc.isCreateParentQueue()) { createParentQueue() } if (apc.isCreatedLeafQueue()) { createLeafQueue() } {code} We should add tests for that because it is contract for future integration, we should have the following test cases: {code:java} 1) when createLeaf = false, createParent = false: 1.1 When both Leaf doesn't exist or Parent doesn't exist: Application will be rejected. 1.2 When Parent exists but Leaf doesnt't exist: Application will be rejected. 1.3 When both exists, application will be accepted 2) Other combinations ..{code} If we can abstract common test functionality, we should be able to do the testing without too much-duplicated code. Can we do it with this patch? *I don't want to delay this (to a separate Jira) because once another feature integration happens (such as from Queue placement policy), we will face issues and will cause further delays.* *2) How we deal with the queue's auto-queue-creation configuration flag?* I think we can create a flag for c-s.xml to enable auto create queue for each parent now, but I felt we need to change it later. As far as we get functionality correct, I'm OK with pushing this to a follow-up patch. > Update queue creation logic to use weight mode and allow the flexible > static/dynamic creation > --------------------------------------------------------------------------------------------- > > Key: YARN-10506 > URL: https://issues.apache.org/jira/browse/YARN-10506 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Benjamin Teke > Assignee: Andras Gyori > Priority: Major > Attachments: YARN-10506-006-10504-010.patch, > YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch, > YARN-10506.001.patch, YARN-10506.002.patch, YARN-10506.003.patch, > YARN-10506.004.patch, YARN-10506.005.patch, YARN-10506.006-combined.patch, > YARN-10506.006.patch, YARN-10506.007.patch, YARN-10506.009.patch, > YARN-10506.011.patch > > > The queue creation logic should be updated to use weight mode and support the > flexible creation. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org