[ 
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829784#comment-13829784
 ] 

Mayank Bansal commented on YARN-967:
------------------------------------

Thanks [~zjshen] for the review 

bq. Please remove it, because it doesn't make sense to AHS, it's used by 
YarnClient#submitApplication
Done

bq. The point is:
bq.1. Before the patch, if the application is not found, 
ApplicationNotFoundException is thrown.
bq. 2. After the patch, if the application is not found in RM, then check AHS. 
If the application is not found in AHS, return null.
Done
bq. In addition, I also suggest looking the behavior of 
ClientRMService#getApplications, and make ApplicationHistoryClientSerivce to 
behave similarly
Right now we are not calling getapplications from CLI to history server, we 
should wait for filters to implement.
bq. 1. The javadoc is still not fixed
Done
bq.2. Then, it's going to reuse the retry policy of RM, which seems not to be 
good. BTW, ContainerManagementProtocolProxy seems not to have the retry policy 
as well. Maybe we should simply create a proxy as HSProxies does?
Done

Thanks,
Mayank

> [YARN-321] Command Line Interface(CLI) for Reading Application History 
> Storage Data
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-967
>                 URL: https://issues.apache.org/jira/browse/YARN-967
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Devaraj K
>            Assignee: Mayank Bansal
>         Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch, 
> YARN-967-4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to