[
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832440#comment-13832440
]
Mayank Bansal commented on YARN-967:
------------------------------------
Thanks [~zjshen] for review
bq. 1. It's better to put it in serviceStart() instead of serviceInit()
its already part of start, however i added the stop in service stop as well
which was missing.
bq. 2. Undo the unnecessary change in YarnCLI.
Done
bq.3. Undo the unnecessary change in RMProxy
Done
bq.4. You may want to move the tests in TestYarnCLI to TestYarnClient, or you
want to test both. Now YarnClient has been changed as well, however,
TestYarnCLI mocks YarnClient and assume the methods work fine.
Done
> [YARN-321] Command Line Interface(CLI) for Reading Application History
> Storage Data
> -----------------------------------------------------------------------------------
>
> Key: YARN-967
> URL: https://issues.apache.org/jira/browse/YARN-967
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Devaraj K
> Assignee: Mayank Bansal
> Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch,
> YARN-967-4.patch, YARN-967-5.patch, YARN-967-6.patch, YARN-967-7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
