[ https://issues.apache.org/jira/browse/YARN-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512336#comment-17512336 ]
András Győri commented on YARN-10548: ------------------------------------- Thanks for the patch [~snemeth]. I had the following additions to it, which could be addressed in a followup: * AMRunner#L83: Type is actually Map.Entry<String, String> * AMRunner#L54: AFAIK SLS is a concurrency-heavy environment, therefore I think this static should at least be an AtomicInteger. > Decouple AM runner logic from SLSRunner > --------------------------------------- > > Key: YARN-10548 > URL: https://issues.apache.org/jira/browse/YARN-10548 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Minor > Attachments: YARN-10548.001.patch, YARN-10548.002.patch, > YARN-10548.003.patch > > > SLSRunner has too many responsibilities. > One of them is to parse the job details from the SLS input formats and > launch the AMs and task containers. > The AM runner logic could be decoupled. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org