[ https://issues.apache.org/jira/browse/YARN-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513456#comment-17513456 ]
Szilard Nemeth commented on YARN-10548: --------------------------------------- Hi [~aajisaka], Thanks for raising YARN-11102. We agreed upon only moving the code in this jira and fix the issue later that are triggered based on the original code. Since the code quality of SLS is in a pretty bad condition, there's simply no way to address all issues in one patch. With YARN-10548, I only moved code around. The old code was modifying the REMAINING_APPS static field from SLSRunner, too. None of these warnings (spotbugs, javac) are triggered because of our code changes, but they are coming from the original code. Also, [~quapaw] had a comment related to that [here|https://issues.apache.org/jira/browse/YARN-10548?focusedCommentId=17512336&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17512336] And [here|https://issues.apache.org/jira/browse/YARN-10548?focusedCommentId=17512463&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17512463] we agreed on a follow-up jira as well. I will fix the Spotbugs and javac issues on YARN-11102. I hope the picture is more clear based on this explanation. Thanks. > Decouple AM runner logic from SLSRunner > --------------------------------------- > > Key: YARN-10548 > URL: https://issues.apache.org/jira/browse/YARN-10548 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Minor > Fix For: 3.4.0 > > Attachments: YARN-10548.001.patch, YARN-10548.002.patch, > YARN-10548.003.patch > > > SLSRunner has too many responsibilities. > One of them is to parse the job details from the SLS input formats and > launch the AMs and task containers. > The AM runner logic could be decoupled. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org