[ https://issues.apache.org/jira/browse/YARN-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577070#comment-17577070 ]
ASF GitHub Bot commented on YARN-10885: --------------------------------------- slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r940815797 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java: ########## @@ -376,10 +378,23 @@ public void updateApplicationHomeSubCluster( */ public SubClusterId getApplicationHomeSubCluster(ApplicationId appId) throws YarnException { - GetApplicationHomeSubClusterResponse response = - stateStore.getApplicationHomeSubCluster( + try { + if (isCachingEnabled()) { + Object value = Review Comment: Thanks for your help reviewing the code, I will fix it. > Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache > ----------------------------------------------------------------------- > > Key: YARN-10885 > URL: https://issues.apache.org/jira/browse/YARN-10885 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: chaosju > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > Yarn Client getApplicationReport function may produce lots of zookeeper ops, > Its import to use the JCache that cache the mapping of application and > subcluster id. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org