[
https://issues.apache.org/jira/browse/YARN-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577642#comment-17577642
]
ASF GitHub Bot commented on YARN-10885:
---------------------------------------
goiri commented on code in PR #4701:
URL: https://github.com/apache/hadoop/pull/4701#discussion_r941833661
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -513,6 +524,25 @@ public Map<String, SubClusterPolicyConfiguration> invoke(
return cacheRequest;
}
+ private Object buildGetApplicationHomeSubClusterRequest(ApplicationId
applicationId) {
+ final String cacheKey = buildCacheKey(getClass().getSimpleName(),
+ GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString());
+ CacheRequest<String, SubClusterId> cacheRequest = new CacheRequest<>(
+ cacheKey,
+ input -> {
+ GetApplicationHomeSubClusterResponse response =
+ stateStore.getApplicationHomeSubCluster(
+
GetApplicationHomeSubClusterRequest.newInstance(applicationId));
Review Comment:
Extract to req
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -513,6 +524,25 @@ public Map<String, SubClusterPolicyConfiguration> invoke(
return cacheRequest;
}
+ private Object buildGetApplicationHomeSubClusterRequest(ApplicationId
applicationId) {
+ final String cacheKey = buildCacheKey(getClass().getSimpleName(),
+ GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString());
+ CacheRequest<String, SubClusterId> cacheRequest = new CacheRequest<>(
+ cacheKey,
+ input -> {
+ GetApplicationHomeSubClusterResponse response =
+ stateStore.getApplicationHomeSubCluster(
+
GetApplicationHomeSubClusterRequest.newInstance(applicationId));
+
+ ApplicationHomeSubCluster applicationHomeSubCluster =
Review Comment:
appHomeSubCluster and one line
> Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache
> -----------------------------------------------------------------------
>
> Key: YARN-10885
> URL: https://issues.apache.org/jira/browse/YARN-10885
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: chaosju
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Yarn Client getApplicationReport function may produce lots of zookeeper ops,
> Its import to use the JCache that cache the mapping of application and
> subcluster id.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
