[ https://issues.apache.org/jira/browse/YARN-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583051#comment-17583051 ]
ASF GitHub Bot commented on YARN-11274: --------------------------------------- Samrat002 commented on code in PR #4783: URL: https://github.com/apache/hadoop/pull/4783#discussion_r951609588 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java: ########## @@ -839,18 +837,15 @@ private boolean handleShutdownOrResyncCommand( if (response.getNodeAction() == NodeAction.SHUTDOWN) { LOG.warn("Received SHUTDOWN signal from Resourcemanager as part of" + " heartbeat, hence shutting down."); - LOG.warn("Message from ResourceManager: " - + response.getDiagnosticsMessage()); + LOG.warn("Message from ResourceManager: {}.", response.getDiagnosticsMessage()); context.setDecommissioned(true); dispatcher.getEventHandler().handle( new NodeManagerEvent(NodeManagerEventType.SHUTDOWN)); return true; } if (response.getNodeAction() == NodeAction.RESYNC) { - LOG.warn("Node is out of sync with ResourceManager," - + " hence resyncing."); - LOG.warn("Message from ResourceManager: " - + response.getDiagnosticsMessage()); + LOG.warn("Node is out of sync with ResourceManager, hence resyncing."); Review Comment: Both can be combined into 1 `LOG.warn` > Improve Nodemanager#NodeStatusUpdaterImpl Log > --------------------------------------------- > > Key: YARN-11274 > URL: https://issues.apache.org/jira/browse/YARN-11274 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Labels: pull-request-available > > 1.When RM performs master-slave switching, NM will re-register, report the > list of running apps, and print the number of running apps > 2.registerWithRM#containerReports is enough to print the number of prints, > because the above calling process has already printed the container list, so > there is no need to repeat printing > 3.Use placeholders to display logs to avoid string concatenation -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org