[
https://issues.apache.org/jira/browse/YARN-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602267#comment-17602267
]
ASF GitHub Bot commented on YARN-11274:
---------------------------------------
slfan1989 commented on code in PR #4783:
URL: https://github.com/apache/hadoop/pull/4783#discussion_r966944820
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java:
##########
@@ -625,7 +625,7 @@ public RegisterNodeManagerResponse registerNodeManager(
@Override
public NodeHeartbeatResponse nodeHeartbeat(NodeHeartbeatRequest request)
throws YarnException, IOException {
- LOG.info("Got heartBeatId: [" + heartBeatID +"]");
+ LOG.info("Got heartBeatId: [{}}]", heartBeatID);
Review Comment:
Thanks for your help reviewing the code. I will modify the code, the last }
is redundant.
> Improve Nodemanager#NodeStatusUpdaterImpl Log
> ---------------------------------------------
>
> Key: YARN-11274
> URL: https://issues.apache.org/jira/browse/YARN-11274
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
>
> 1.When RM performs master-slave switching, NM will re-register, report the
> list of running apps, and print the number of running apps
> 2.registerWithRM#containerReports is enough to print the number of prints,
> because the above calling process has already printed the container list, so
> there is no need to repeat printing
> 3.Use placeholders to display logs to avoid string concatenation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
