[
https://issues.apache.org/jira/browse/YARN-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616289#comment-17616289
]
ASF GitHub Bot commented on YARN-11216:
---------------------------------------
K0K0V0K commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r993197109
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -1200,7 +1207,24 @@ public ConfigurationProperties
getConfigurationProperties() {
public void reinitializeConfigurationProperties() {
// Props are always Strings, therefore this cast is safe
Map<String, String> props = (Map) getProps();
- configurationProperties = new ConfigurationProperties(props);
+ configurationProperties = new ConfigurationProperties(props, PREFIX);
+ }
+
+ @Override
+ public void set(String name, String value) {
+ super.set(name, value);
+ if (configurationProperties != null) {
+ //The super#get method used cause the super#set contains some logic
+ configurationProperties.set(super.get(name), value);
Review Comment:
I think we should keep them in sync, cause if later someone wants to use the
deprecation feature here, than a bug can be easily made
> Avoid unnecessary reconstruction of ConfigurationProperties
> -----------------------------------------------------------
>
> Key: YARN-11216
> URL: https://issues.apache.org/jira/browse/YARN-11216
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: András Győri
> Assignee: Bence Kosztolnik
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> ConfigurationProperties is expensive to create, however, due to its immutable
> nature it is possible to copy it/share it between configuration objects (eg.
> create a copy constructor).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
