[ 
https://issues.apache.org/jira/browse/YARN-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656106#comment-17656106
 ] 

ASF GitHub Bot commented on YARN-11216:
---------------------------------------

K0K0V0K commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r1064638015


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerConfiguration.java:
##########
@@ -107,6 +110,40 @@ public void testDefaultSubmitACLForRootAllAllowed() {
     assertTrue(acl.isAllAllowed());
   }
 
+  /**
+   * dfs.nfs.exports.allowed.hosts
+   * prop is deprecated, now we use
+   * nfs.exports.allowed.hosts
+   * instead
+   */
+  @Test
+  public void testDeprecationFeatureWorks() {

Review Comment:
   When we set a deprecated properite, there is some logic under the hood what 
keeps the old value and add an alias to the properties object, and we have to 
ensure the alias add also present in the tree.
   
   The unset unfortunately not works fine, but i created a ticket for that
   https://issues.apache.org/jira/browse/YARN-11348





> Avoid unnecessary reconstruction of ConfigurationProperties
> -----------------------------------------------------------
>
>                 Key: YARN-11216
>                 URL: https://issues.apache.org/jira/browse/YARN-11216
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: András Győri
>            Assignee: Bence Kosztolnik
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> ConfigurationProperties is expensive to create, however, due to its immutable 
> nature it is possible to copy it/share it between configuration objects (eg. 
> create a copy constructor). 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to