[
https://issues.apache.org/jira/browse/YARN-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655484#comment-17655484
]
ASF GitHub Bot commented on YARN-11408:
---------------------------------------
brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1063534266
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -309,6 +311,11 @@ private void checkMaxChildCapacitySetting(FSQueue queue) {
}
}
+ private boolean checkAutoQueueCreationV2Disabled(String queueName) {
+ return !Objects.equals(capacitySchedulerConfig.get(
+ PREFIX + queueName + DOT + AUTO_QUEUE_CREATION_V2_ENABLED), "true");
Review Comment:
This won't return true because Object.equals only returns true if both of
the compared objects refer to the same object, String.equals compares the
values themselves. But CapacitySchedulerConfiguration already has a helper
method which parses the value to a boolean, so I suggest using that. See
isAutoQueueCreationV2Enabled.
Also if percentage mode is used when converting it'll have the legacy Auto
Queue Creation property, which too has a helper method, called
isAutoCreateChildQueueEnabled. Both of these should be checked.
> Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor
> method
> ------------------------------------------------------------------------------------
>
> Key: YARN-11408
> URL: https://issues.apache.org/jira/browse/YARN-11408
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> It is required to add user-limit-factor to -1 only for those queues which are
> leafqueue and auto-queue-creation is disabled.
> Follow-up of YARN-11393
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
