[
https://issues.apache.org/jira/browse/YARN-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672295#comment-17672295
]
ASF GitHub Bot commented on YARN-11408:
---------------------------------------
brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1066819718
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -309,6 +314,18 @@ private void checkMaxChildCapacitySetting(FSQueue queue) {
}
}
+ private boolean checkAutoQueueCreationV2Disabled(String queueName) {
+ return !capacitySchedulerConfig.getBoolean(
+ PREFIX + queueName + DOT + AUTO_QUEUE_CREATION_V2_ENABLED,
+ DEFAULT_AUTO_QUEUE_CREATION_ENABLED);
+ }
+
+ private boolean checkAutoCreateChildQueueDisabled(String queueName) {
+ return !capacitySchedulerConfig.getBoolean(
+ PREFIX + queueName + DOT + AUTO_CREATE_CHILD_QUEUE_ENABLED,
+ DEFAULT_AUTO_CREATE_CHILD_QUEUE_ENABLED);
+ }
Review Comment:
Ohh, the tricky thing is that capacitySchedulerConfig is in reality a
Configuration object, and not a CapacitySchedulerConfiguration object. This is
misleading (and it means that every convenience getter will be reimplemented
here), so I've created a follow-up:
https://issues.apache.org/jira/browse/YARN-11416. Resolving this conversation
for this patch.
> Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor
> method
> ------------------------------------------------------------------------------------
>
> Key: YARN-11408
> URL: https://issues.apache.org/jira/browse/YARN-11408
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> It is required to add user-limit-factor to -1 only for those queues which are
> leafqueue and auto-queue-creation is disabled.
> Follow-up of YARN-11393
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
