[
https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888329#comment-13888329
]
Zhijie Shen commented on YARN-1659:
-----------------------------------
Billie, thanks for the patch. Here're some general comments:
1. Would you please add the javadoc at the class level, including public inner
classes and enums?
2. Please add some simple javadoc for the setter/getter in the store-faced pojo
classes as well?
3. Change event.ts->event.timestamp?
4. Like YARN-1633, write a simple test case for the pjo classes?
5. Make sure the license block start witl "/**"
> Define ApplicationTimelineStore interface and store-facing entity,
> entity-info and event objects
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-1659
> URL: https://issues.apache.org/jira/browse/YARN-1659
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch,
> YARN-1659-5.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface. The web services
> will convert the store-facing obects to the user-facing objects.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
