[ 
https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888752#comment-13888752
 ] 

Billie Rinaldi commented on YARN-1659:
--------------------------------------

I agree removing Entity is a good idea.  I've made the change, and will just 
wait for Zhijie's feedback before I upload another patch.

Regarding the field names, the API retrieves objects that look like the 
following, where entity and entitytype are mandatory and the remaining fields 
are optional.  I think it makes sense to have the enum values for Field match 
these field names, as opposed to having to do some translation between the two. 
 But it's not a big deal, I can add the underscores if you would prefer.  
{noformat}
  {
    "entity": ...,
    "entitytype": ...
    "relatedentities": ...,
    "primaryfilters": ...,
    "secondaryfilters": ...,
    "otherinfo": ...,
  }
{noformat}

> Define ApplicationTimelineStore interface and store-facing entity, 
> entity-info and event objects
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1659
>                 URL: https://issues.apache.org/jira/browse/YARN-1659
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch, 
> YARN-1659-5.patch, YARN-1659-6.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface.  The web services 
> will convert the store-facing obects to the user-facing objects.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to