[ https://issues.apache.org/jira/browse/YARN-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004803#comment-14004803 ]
Binglin Chang commented on YARN-2088: ------------------------------------- Based on recent bugs related to api records/PBImpl, I have some doubts about the general patterns used in PBImpls(java fields mixed with proto objects, cached states), which causes lots of redundant code and confusion, changes to those code is a mental challenge and can easily generate new bugs... > Fix code bug in GetApplicationsRequestPBImpl#mergeLocalToBuilder > ---------------------------------------------------------------- > > Key: YARN-2088 > URL: https://issues.apache.org/jira/browse/YARN-2088 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Binglin Chang > Assignee: Binglin Chang > Attachments: YARN-2088.v1.patch > > > Some fields(set,list) are added to proto builders many times, we need to > clear those fields before add, otherwise the result proto contains more > contents. -- This message was sent by Atlassian JIRA (v6.2#6252)