[ 
https://issues.apache.org/jira/browse/YARN-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005602#comment-14005602
 ] 

Hong Zhiguo commented on YARN-2088:
-----------------------------------

+1

I guess the failure before this patch is caused by 
builder.clearApplicationTags() being not called in setApplicationTags() or 
mergeLocalToBuilder().

2 lines as below could be cleaned away too.
{code}
 public GetApplicationsRequestProto getProto() {
     mergeLocalToProto();
-    proto = viaProto ? proto : builder.build();
-    viaProto = true;
     return proto;
 }
{code}



> Fix code bug in GetApplicationsRequestPBImpl#mergeLocalToBuilder
> ----------------------------------------------------------------
>
>                 Key: YARN-2088
>                 URL: https://issues.apache.org/jira/browse/YARN-2088
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2088.v1.patch
>
>
> Some fields(set,list) are added to proto builders many times, we need to 
> clear those fields before add, otherwise the result proto contains more 
> contents.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to