[
https://issues.apache.org/jira/browse/YARN-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183416#comment-14183416
]
Wangda Tan commented on YARN-2505:
----------------------------------
Hi [~cwelch],
Thanks for the patch, generally looks good to me, some minor comments:
1) ApplicationSubmissionContextInfo:
According to names in ApplicationSubmissionContxt,
appLabelExpression -> appNodeLabelExpression
amContainerLabelExpression -> amContainerNodeLabelExpression
And also names of getters/setters
2) RMWebServices,
2.1 It's better to save the reference to RMNodeLabelsManager instead of get it
in RMContext everytime.
2.2 Get method like getClusterNodeLabels don't need throw AuthorizationException
2.3 I would suggest to add user name and method being used when callUGI is null
or checkAccess returns false. Like "User=john not authorized for
action=removeFromClusterNodeLabels" for easier debugging purpose.
At first I thought it is wrong to put colon(:) to URL, but I found it should be
safe to do that, according to
http://stackoverflow.com/questions/2053132/is-a-colon-safe-for-friendly-url-use.
So that shouldn't be a problem.
Thanks,
Wangda
> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>
> Key: YARN-2505
> URL: https://issues.apache.org/jira/browse/YARN-2505
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Craig Welch
> Attachments: YARN-2505.1.patch, YARN-2505.3.patch, YARN-2505.4.patch,
> YARN-2505.5.patch, YARN-2505.6.patch, YARN-2505.7.patch, YARN-2505.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
