[
https://issues.apache.org/jira/browse/YARN-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201884#comment-14201884
]
Sandy Ryza commented on YARN-2811:
----------------------------------
Cool, thanks for the updated patch. Are you able to add a test to verify the
behavior? A couple nits:
{code}
+ if (Resources.fitsIn(queue.getResourceUsage(), queue.scheduler
+ .getAllocationConfiguration().getMaxResources(queue.getName()))) {
{code}
Since we're in FairScheduler, can we just access the allocation configuration
directly?
{code}
//Don't hold the reservation if queue reaches its maximum
{code}
Double slashes should have a space after them.
> Fair Scheduler is violating max memory settings in 2.4
> ------------------------------------------------------
>
> Key: YARN-2811
> URL: https://issues.apache.org/jira/browse/YARN-2811
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Siqi Li
> Assignee: Siqi Li
> Attachments: YARN-2811.v1.patch, YARN-2811.v2.patch,
> YARN-2811.v3.patch
>
>
> This has been seen on several queues showing the allocated MB going
> significantly above the max MB and it appears to have started with the 2.4
> upgrade. It could be a regression bug from 2.0 to 2.4
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
