[ https://issues.apache.org/jira/browse/YARN-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208403#comment-14208403 ]
Sandy Ryza commented on YARN-2811: ---------------------------------- IIUC, this looks like it will check the immediate parent of the queue, but won't go any farther up in the hierarchy. Can fitsIn be given a more descriptive name, like fitsInMaxShares? Last, to avoid code duplication, can the check be moved into this same if statement: {code} if (!reservedAppSchedulable.hasContainerForNode(reservedPriority, node)) { {code} > Fair Scheduler is violating max memory settings in 2.4 > ------------------------------------------------------ > > Key: YARN-2811 > URL: https://issues.apache.org/jira/browse/YARN-2811 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.4.0 > Reporter: Siqi Li > Assignee: Siqi Li > Attachments: YARN-2811.v1.patch, YARN-2811.v2.patch, > YARN-2811.v3.patch, YARN-2811.v4.patch, YARN-2811.v5.patch > > > This has been seen on several queues showing the allocated MB going > significantly above the max MB and it appears to have started with the 2.4 > upgrade. It could be a regression bug from 2.0 to 2.4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)