[
https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233812#comment-14233812
]
Wangda Tan commented on YARN-2762:
----------------------------------
Hi [~rohithsharma],
Thanks for working on this, the trimming itself looks good to me, but some
comments about error message handling
I think we should make the error message more consistent, my suggestion is:
- If no labels specified when adding/removing labels, the message is "No
cluster node-labels are specified"
- If no node-to-labels mapping specified when replace labels, the message is
"No node-to-labels mappings are specified"
And we should make the two kinds of error message as a pre-defined final field
of RMAdminCLI.
Thoughts?
> RMAdminCLI node-labels-related args should be trimmed and checked before
> sending to RM
> --------------------------------------------------------------------------------------
>
> Key: YARN-2762
> URL: https://issues.apache.org/jira/browse/YARN-2762
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith
> Assignee: Rohith
> Priority: Minor
> Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done
> at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can
> be skipped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
