[
https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236384#comment-14236384
]
Wangda Tan commented on YARN-2762:
----------------------------------
[~sunilg],
Thanks for comment,
#1, #3 makes sense to me, and #3 could be added to TestRMAdminCLI,
I suggest to make patch clean, #2 could be done in another JIRA
[~rohithsharma],
Thanks for updating,
With my above comment, patch looks good to me,
Wangda
> RMAdminCLI node-labels-related args should be trimmed and checked before
> sending to RM
> --------------------------------------------------------------------------------------
>
> Key: YARN-2762
> URL: https://issues.apache.org/jira/browse/YARN-2762
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith
> Assignee: Rohith
> Priority: Minor
> Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch,
> YARN-2762.3.patch, YARN-2762.4.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done
> at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can
> be skipped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
