[ https://issues.apache.org/jira/browse/YARN-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391067#comment-14391067 ]
Wangda Tan commented on YARN-2729: ---------------------------------- Hi [~Naganarasimha], Sorry for my late response, bq. Also as per Jian Fang he wanted some kind of configuration such that the timer task doesn't run, as their usecase requires updating of node labels only during registration and do not want timer to continuously running for this. So do we need to support this (as unnecessary additional timer thread will be running) ? and if so can we check for interval-ms and decide based on its value (0 or -1 to not to launch the timer task) ? Interval-ms is configurable as we decided, I think it will be fine if we don't launch timer (if don't launch timer is just a simple change), or you can just set timer to a very big value that it will never get launched. bq. whether to do the changes required to make HadoopCommon's NodeHealthScriptRunner reuseable (In seperate jira) and rework on ScriptBasedNodeLabelsProvider ? You already have a ScriptBasedNodeLabelsProvider, use it now and we can see if there's chance to merge it to NodeHealthScriptRunner in the future (low priority). And did you forgot add "ScriptBasedNodeLabelsProvider" in your latest patch? > Support script based NodeLabelsProvider Interface in Distributed Node Label > Configuration Setup > ----------------------------------------------------------------------------------------------- > > Key: YARN-2729 > URL: https://issues.apache.org/jira/browse/YARN-2729 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Fix For: 2.8.0 > > Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch, > YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch, > YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch, > YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch > > > Support script based NodeLabelsProvider Interface in Distributed Node Label > Configuration Setup . -- This message was sent by Atlassian JIRA (v6.3.4#6332)